fix: correct InvalidCustomPropertyError code and MemoryStore promise handling#2853
Merged
Conversation
…handling - InvalidCustomPropertyError now uses ErrorCode.InvalidCustomPropertyError instead of AppInitializationError - MemoryStore.get() adds return statements after resolve/reject to prevent promise double settlement
WilliamBergamin
added
bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 44 44
Lines 7853 7855 +2
Branches 686 687 +1
=======================================
+ Hits 7350 7352 +2
Misses 498 498
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamBergamin
approved these changes
Apr 8, 2026
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
These are some nice finds 💯 both of these seem to be legit bugs 🥇
Thank you for your contribution to find and fix these 🙏
Contributor
Author
|
Hey thank you very much for accepting my pull request :) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
InvalidCustomPropertyError: The error class was incorrectly using the wrong error code and now correctly uses the appropriate one.
MemoryStore.get(): Added missing
returnstatements afterresolve()andreject()calls to prevent promise double settlement and ensure proper async flow control.Changes
InvalidCustomPropertyErrorclassMemoryStore.get()promise handlers to prevent multiple resolutions/rejectionsRequirements